Skip to content

Comments

hedgewars: Disable autoupdate on darwin to fix build#191699

Closed
maralorn wants to merge 1 commit intoNixOS:haskell-updatesfrom
maralorn:hedgewars-darwin
Closed

hedgewars: Disable autoupdate on darwin to fix build#191699
maralorn wants to merge 1 commit intoNixOS:haskell-updatesfrom
maralorn:hedgewars-darwin

Conversation

@maralorn
Copy link
Member

On darwin cmake complains about missing Sparkle. Autoupdates don‘t seem important for a nixpkgs package, so we disable it.

See: https://hydra.nixos.org/build/190503204/nixlog/4 for the error.

\cc @fpletz @kragniz

I can‘t test this on darwin, I will only be able to tell after merging.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

On darwin cmake complains about missing Sparkle. Autoupdates don‘t seem important for a nixpkgs package, so we disable it.

See: https://hydra.nixos.org/build/190503204/nixlog/4 for the error.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 17, 2022
@sternenseemann
Copy link
Member

@ofborg build hedgewars

@ofborg ofborg bot requested review from fpletz and kragniz September 17, 2022 19:48
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 17, 2022
@maralorn
Copy link
Member Author

As witnessed by ofBorg this just let’s the build proceed to another failure.

@maralorn maralorn marked this pull request as draft September 17, 2022 20:32
@fpletz
Copy link
Member

fpletz commented Sep 19, 2022

Unfortunately, I also can't test or fix this since I don't have Darwin either. I would propose to disable builds for Darwin for now. We should also disable the autoupdate in nixpkgs. 👍

@maralorn
Copy link
Member Author

If have done this in e678b76.

@maralorn maralorn closed this Sep 20, 2022
@maralorn maralorn deleted the hedgewars-darwin branch September 20, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants